Fix path::deep_dependencies_trigger_rebuild often failing in CI #5952
Conversation
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
👍 This should fix this particular test. |
|
r=ehuss? |
|
Hm is this the right fix? The test here is that if we change a file it'll cause a rebuild, but the sleep has to be before the file is edited to simulate time passing between the build and the edit? |
|
I'm not sure I understand. Any change that happens between builds should trigger a rebuild, regardless of when it is made. The problem is in this test:
If step 2 is done immediately before 3, the mtime of If you sleep after the files are modified, then the output mtime for baz will be N+1 in step 3, so it won't recompile baz in step 5 because N < N+1. |
|
📌 Commit 274c162 has been approved by |
…uild, r=alexcrichton Fix path::deep_dependencies_trigger_rebuild often failing in CI A shallow fix for `path::deep_dependencies_trigger_rebuild` in particular as it's failed my PRs often. See #5935 (comment), and #5940 for the bigger picture.
|
☀️ Test successful - status-appveyor, status-travis |
A shallow fix for
path::deep_dependencies_trigger_rebuildin particular as it's failed my PRs often.See #5935 (comment), and #5940 for the bigger picture.